Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix upgrade not showing when an RC is deployed #513

Merged
merged 8 commits into from
Oct 5, 2020
Merged

Fix upgrade not showing when an RC is deployed #513

merged 8 commits into from
Oct 5, 2020

Conversation

nwmac
Copy link
Member

@nwmac nwmac commented Oct 2, 2020 •
edited
Loading

Fixes #512

@nwmac nwmac added bug Something isn't working ready for review Ready for review labels Oct 2, 2020
@nwmac nwmac self-assigned this Oct 2, 2020
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2020 •
edited
Loading

Codecov Report

Merging #513 into master will increase coverage by 0.04%.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##           master     #513      +/-   ##
==========================================
+ Coverage   57.80%   57.85%   +0.04%     
==========================================
  Files        1061     1061              
  Lines       34403    34418      +15     
  Branches     4891     4898       +7     
==========================================
+ Hits        19888    19912      +24     
+ Misses      14515    14506       -9

richard-cox
richard-cox requested changes Oct 5, 2020
View reviewed changes
...ackages/kubernetes/src/kubernetes/workloads/release/tabs/helm-release-helper.service.spec.ts Outdated
@@ -0,0 +1,28 @@
import { Version } from './helm-release-helper.service';

fdescribe('HelmReleaseHelperService', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fdescribe

...end/packages/kubernetes/src/kubernetes/workloads/release/tabs/helm-release-helper.service.ts Outdated
@@ -224,6 +245,8 @@ export class HelmReleaseHelperService {
if (c.relationships && c.relationships.latestChartVersion && c.relationships.latestChartVersion.data) {
const latest = new Version(c.relationships.latestChartVersion.data.version);
const current = new Version(release.chart.metadata.version);
console.log(latest);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

console.log

@richard-cox richard-cox added the needs attention Needs attention label Oct 5, 2020
@nwmac nwmac added comments-addressed and removed needs attention Needs attention labels Oct 5, 2020
richard-cox
richard-cox approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge once passed gates

@richard-cox
Copy link
Member

I'm going to merge this to unblock downstream merge. Unit tests have passed and the only other change is removal of logging

@richard-cox richard-cox merged commit 41737ca into master Oct 5, 2020
@richard-cox richard-cox deleted the fix-helm-upgrade-rc branch October 5, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-cox richard-cox richard-cox approved these changes

Assignees

@nwmac nwmac

Labels
bug Something isn't working comments-addressed ready for review Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workloads does not show upgrade available for an installed RC
3 participants
@nwmac @codecov-commenter @richard-cox